Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of boolean examples on the elements theme #887

Merged

Conversation

dfsmania
Copy link
Contributor

@dfsmania dfsmania commented Sep 5, 2024

This PR fix the rendering of boolean examples with the elements theme. Currently, there's an issue and boolean example cases like false and true aren't rendering in the right way. At next you can see an image showing this issue:

Previous to this PR

Screenshot 2024-09-05 at 11-27-01 The Giga Provisioning API

In this image you can see that a false example value is not rendered and true is rendered like 1.

After this PR

Screenshot 2024-09-05 at 11-27-52 The Giga Provisioning API

In this image you can see that boolean example cases are now rendering nicely.

@shalvah
Copy link
Contributor

shalvah commented Sep 7, 2024

Thanks!

@shalvah shalvah merged commit 18e873f into knuckleswtf:master Sep 7, 2024
6 checks passed
@dfsmania dfsmania deleted the fix_bool_examples_on_elements_theme branch September 7, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants