feat(organizations): add functions for managing members TASK-985 #5281
+63
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-endpoints-to-handle-org-members
… query for user mfa details
…hook more customizable and then use it in `MembersRoute`
…hook more customizable and then use it in `MembersRoute`
…x/kpi into leszek/task-980-members-table
…eszek/task-980-members-table
…omprehensive tests
…omprehensive tests
…eszek/task-980-members-table
…x/kpi into leszek/task-980-members-table
…eszek/task-980-members-table
…x/kpi into leszek/task-980-members-table
magicznyleszek
changed the base branch from
main
to
leszek/task-980-members-table
…ber-mutation-api # Conflicts: # jsapp/js/account/organizations/membersQuery.ts
magicznyleszek
commented
Nov 20, 2024
…eszek/task-980-members-table # Conflicts: # jsapp/js/account/organization/MembersRoute.tsx # jsapp/js/account/organization/membersQuery.ts # jsapp/js/account/organization/membersRoute.module.scss # jsapp/js/account/routes.constants.ts # jsapp/js/account/routes.tsx # jsapp/js/api.endpoints.ts
…ber-mutation-api # Conflicts: # jsapp/js/account/organization/membersQuery.ts
magicznyleszek
requested review from
p2edwards
and removed request for
p2edwards
# Conflicts: # jsapp/js/account/organization/MembersRoute.tsx # jsapp/js/account/organization/membersQuery.ts # jsapp/js/api.endpoints.ts # kobo/apps/organizations/serializers.py # kobo/apps/organizations/views.py
9 tasks
Akuukis
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM, not tested. I like how simple getMemberEndpoint approach is, for now let's stick to that.
Once we get to API schema auto-generation and auto-generated types, preferrably with auto-generated helpers, then let's worry later about what concerns and restrictions that will bring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234frontendorbackendunless it's global💭 Notes
Not testable per se until further PR is built atop this one and uses it :)