-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(organizations): add Organization Settings route TASK-981 #5299
Open
magicznyleszek
wants to merge
23
commits into
leszek/task-1219-org-settings-mutating
Choose a base branch
from
kalvis/organizations-settings
base: leszek/task-1219-org-settings-mutating
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(organizations): add Organization Settings route TASK-981 #5299
magicznyleszek
wants to merge
23
commits into
leszek/task-1219-org-settings-mutating
from
kalvis/organizations-settings
+268
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # jsapp/js/account/organization/OrganizationSettingsField.tsx # jsapp/js/account/organization/organizationSettingsRoute.module.scss
magicznyleszek
changed the title
feaet(organizations): add Organization Settings route TASK-981
feat(organizations): add Organization Settings route TASK-981
Nov 26, 2024
magicznyleszek
changed the base branch from
main
to
leszek/task-1219-org-settings-mutating
December 3, 2024 14:39
magicznyleszek
requested review from
jnm,
noliveleger and
rgraber
as code owners
December 3, 2024 14:39
…anizations-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Checklist
<type>(<scope>)<!>: <title> TASK-1234
frontend
orbackend
unless it's global📣 Summary
In Organization Settings route (
#/account/organization/settings
) display editable organization name, and website. Also display non-editable organization type.📖 Description
Only some roles allow editing the fields, and there is some logic in regards to fields being visible.
👀 Preview steps
mmosEnabled
#/account/organization/settings
Next steps:
#/account/organization/settings
💭 Notes
Includes
planName
code being moved out ofjsapp/js/account/usage/yourPlan.component.tsx
intojsapp/js/account/subscriptionStore.ts
so it can be used in both places now.