Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): add Organization Settings route TASK-981 #5299

Open
wants to merge 23 commits into
base: leszek/task-1219-org-settings-mutating
Choose a base branch
from

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Nov 25, 2024

🗒️ Checklist

  1. run linter locally
  2. update all related docs (API, README, inline, etc.), if any
  3. draft PR with a title <type>(<scope>)<!>: <title> TASK-1234
  4. tag PR: at least frontend or backend unless it's global
  5. fill in the template below and delete template comments
  6. review thyself: read the diff and repro the preview as written
  7. open PR & confirm that CI passes
  8. request reviewers, if needed
  9. delete this section before merging

📣 Summary

In Organization Settings route (#/account/organization/settings) display editable organization name, and website. Also display non-editable organization type.

📖 Description

Only some roles allow editing the fields, and there is some logic in regards to fields being visible.

👀 Preview steps

  1. for one of the users (e.g. "joe"), use http://kf.kobo.local/admin/organizations/organization/ to enable "Multi-members override" (for "joe's organization")
  2. enable feature flag mmosEnabled
  3. navigate to #/account/organization/settings
  4. 🟢 notice that at least "Team name"/"Organization name" field is being displayed and is editable(-ish)
  • Editing the field doesn't do anything yet - this will be implemented in next PR
  1. 🟢 if you have enabled Stripe - notice that "Team website"/"Organization website" field and "Team type"/"Organzation type" (non editable) fields are also being displayed

Next steps:

  1. for another user (e.g. "zoe"), use http://kf.kobo.local/admin/organizations/organization/ to add "zoe" into "joe's organization"
  2. logged in as "zoe", navigate to #/account/organization/settings
  3. 🟢 notice that at least "Team name"/"Organization name" field is being displayed (non editable)
  4. 🟢 if you have enabled Stripe - notice that "Team website"/"Organization website" field and "Team type"/"Organzation type" fields are also being displayed (both non editable)

💭 Notes

Includes planName code being moved out of jsapp/js/account/usage/yourPlan.component.tsx into jsapp/js/account/subscriptionStore.ts so it can be used in both places now.

@magicznyleszek magicznyleszek changed the title feaet(organizations): add Organization Settings route TASK-981 feat(organizations): add Organization Settings route TASK-981 Nov 26, 2024
@magicznyleszek magicznyleszek marked this pull request as ready for review November 26, 2024 19:33
@magicznyleszek magicznyleszek changed the base branch from main to leszek/task-1219-org-settings-mutating December 3, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants