fix(projectHistoryLogs): rename incorrectly-formatted action TASK-944 #5320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Checklist
<type>(<scope>)<!>: <title> TASK-1234
frontend
orbackend
unless it's globalπ£ Summary
Change the action
modify_sharing
tomodify-sharing
in project history logs for consistency.π· Description for instance maintainers
Change the AuditAction
modify_sharing
tomodify-sharing
, including a migration to update existing logs. Also adds the migration for all the new audit action types, although this migration seems to be a no-op in SQL.π Preview steps
api/v2/assets/<uid>/history
. Notice the action for the latest project history log ismodify_sharing
modify-sharing
modify-sharing
π Notes
I didn't even realize this needed a migration until I ran
./manage makemigrations audit_log
. It seems to work fine without the migration but this way there will be no unexpected changes next time we have to make a real migration.The migration of existing logs should be pretty light since it's a fairly rare type of log.