perf(organization): reduce DB queries even further for owner label in asset list TASK-1181 #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
noliveleger
changed the title
noliveleger
changed the base branch from
task-1181-add-owner_label-field-to-asset-serializer
to
main
… github.com:kobotoolbox/kpi into task-1181-add-owner_label-field-to-asset-serializer
…to task-1181-optimization-db-queries-on-org
noliveleger
requested review from
rajpatel24 and
jnm
and removed request for
jnm
noliveleger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Reduced query count to minimize load and enhance scalability.
💭 Notes
Some optimizations were already introduced in #5312, but in certain circumstances, Django still ignores the
prefetch_relatedand executes a query for each organization load. By assigning the preloaded data to a new dedicated property, we ensure Django does not attempt to fetch the object again, effectively preventing unnecessary queries.