Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use django storage to handle file objects #5325

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: use django storage to handle file objects #5325

merged 2 commits into from
Dec 4, 2024

Conversation

noliveleger
Copy link
Contributor

📣 Summary

For dev interests. Replace open and os.path with Django storage utility (i.e: from django.core.files.storage import default_storage)

@noliveleger noliveleger self-assigned this Dec 4, 2024
@noliveleger noliveleger requested a review from jnm as a code owner December 4, 2024 16:23
@noliveleger noliveleger removed the request for review from jnm December 4, 2024 16:23
RuthShryock
RuthShryock approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@RuthShryock RuthShryock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noliveleger noliveleger merged commit 70407e3 into main Dec 4, 2024
4 checks passed
@noliveleger noliveleger deleted the fix-unit-test-for-s3 branch December 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuthShryock RuthShryock RuthShryock approved these changes

Assignees

@noliveleger noliveleger

Labels
Back end bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noliveleger @RuthShryock