Add ECKeypair doc for :model module #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigman212
commented
Oct 8, 2023
| destinationDirectory: File, | ||
| config: ScryptConfig) = createWallet(password, config).let { wallet -> | ||
| fun ECKeyPair.generateWalletFile( | ||
| password: String, |
There was a problem hiding this comment.
sorry, but these indents were something else :)
bigman212
commented
Oct 8, 2023
| val walletFile = load(SCRYPT_TEST_JSON) | ||
| val (privateKey) = walletFile.toTypedWallet().decrypt(PASSWORD) | ||
| assertThat(privateKey.key.toHexStringNoPrefix()).isEqualTo(PRIVATE_KEY_STRING) | ||
| val walletFile = loadWalletFile(SCRYPT_TEST_JSON) |
There was a problem hiding this comment.
all unit tests are green, just a small variable extraction to make it more readable
Co-authored-by: ligi <ligi@ligi.de>
Co-authored-by: ligi <ligi@ligi.de>
|
@ligi feel free to merge. |
ligi
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to help and write some documentation on how to use this lib.
I haven't done much here - I want to ensure this is what you want.
https://dillinger.io/ - to preview readme