You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle automount and secret for existing service account
Motivation and Context
Existing service account prior to upgrade to kubernetes 1.26 were created without automount.
It means, on start up syncronize service account must check if existing service account has automount. If not, set to true and create corresponding Secret Type ServiceAccountToken https://intelygenz.atlassian.net/browse/KDL6-112
PR Checklist
Please check if your PR fulfills the following requirements:
I have created tests for my code changes, and the tests are passing.
Tests for the changes have been added (for bug fixes / features)
My change requires a change to the documentation (create a new issue if the documentation has not been updated).
PR Type
What kind of change does this PR introduce?
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
Other... Please describe:
What is the current behavior?
Service accounts created prior to migration to kubernetes 1.26 dont have autmount set to true and corresponding Secret Type ServiceAccountToken. With this change, if service account doesn´t have autmount to true, service account will be updated and secret created.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle automount and secret for existing service account
Motivation and Context
Existing service account prior to upgrade to kubernetes 1.26 were created without automount.
It means, on start up syncronize service account must check if existing service account has automount. If not, set to true and create corresponding Secret Type ServiceAccountToken
https://intelygenz.atlassian.net/browse/KDL6-112
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Service accounts created prior to migration to kubernetes 1.26 dont have autmount set to true and corresponding Secret Type ServiceAccountToken. With this change, if service account doesn´t have autmount to true, service account will be updated and secret created.
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information