Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration and Refactoring #6

Merged
merged 16 commits into from
Dec 15, 2022
Merged

Migration and Refactoring #6

merged 16 commits into from
Dec 15, 2022

Conversation

JiriLojda
Copy link
Member

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Code has been tested in a private Zapier integration
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@JiriLojda JiriLojda removed the request for review from kentico-ericd November 22, 2022 12:21
@JiriLojda
Copy link
Member Author

Fixes #4

Simply007
Simply007 suggested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of the review

README.md Outdated Show resolved Hide resolved
src/utils/hasValidSignature.ts Show resolved Hide resolved
src/actions/changeContentItemWorkflow.ts Show resolved Hide resolved
src/fields/elements/getContentTypeElements.ts Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
index.js Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
src/utils/getSecret.ts Outdated Show resolved Hide resolved
src/utils/types/getContentTypes.ts Show resolved Hide resolved
@JiriLojda
Add tests
778c9c7
@JiriLojda
Export InputData types from public actions
6c83301 
- Make public actions' keys string literals
- Fix date formatting in actions' output
@JiriLojda
Adjust jest config and CI builds
8a5af12 
- use node 16.x on CI as that is the latest version supported by Zapier
- fix jest test finding
@JiriLojda
Fix build by explicit include in tsconfig
06f80d5
@JiriLojda
Copy link
Member Author

Fixes #3

Simply007
Simply007 reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of the last notes - once resolved, we can merge

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
JiriLojda and others added 2 commits December 15, 2022 10:29
@JiriLojda @Simply007
Remove return statement from code examples
7cfde6a 
Co-authored-by: Ondřej Chrastina <9218736+Simply007@users.noreply.github.com>
@JiriLojda
Rename deply workflow to build as it doesn't deploy anything
aedfcba
Simply007
Simply007 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@JiriLojda JiriLojda merged commit b88f577 into master Dec 15, 2022
@JiriLojda JiriLojda deleted the migration branch December 15, 2022 14:58
This was referenced Dec 15, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokornyd pokornyd pokornyd left review comments

@Simply007 Simply007 Simply007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JiriLojda @Simply007 @pokornyd