KCL-11649 - Centralize smart link instance to context. provide smart … #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When working on the sample site, I faced a problem of having multiple places with
useSmartLink
and not being sure if I could spin up more instances of SmartLink SDK.I sometimes even got error saying something about SmartLink SDK being destroyed already. Unfortunately cannot reproduce reliably.
I reorganized SmartLink initialization code the following way:
SmartLinkProvider
and exposed the SmartLink SDK instance via contextuseSmartLink
- Gives access to the SmartLink SDK singletonuseSmartLinkRefresh
- Attaches the refresh callback to the SmartLink SDK, greatly reducing the boilerplate to handle page refresh (used on the Home page)Checklist
How to test
When previewing in Web spotlight, the SmartLink actions should work (edit element / auto-refresh)