Домашка Зайцев ДА #260
Open
Домашка Зайцев ДА #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-zhelonkin
reviewed
Nov 18, 2024
| public class CircularCloudLayouter_Tests | ||
| { | ||
|
|
||
| private CircularCloudLayouter CCL; |
There was a problem hiding this comment.
Не надо, пж, аббревиатуры. Ладно еще неполное имя, но вот так ни в коем случае
| var testResult = TestContext.CurrentContext.Result.Outcome; | ||
| var testName = TestContext.CurrentContext.Test.Name; | ||
| if (Equals(testResult, ResultState.Failure) || | ||
| Equals(testResult == ResultState.Error)) |
There was a problem hiding this comment.
Для чего вот эта штука? Думаю, тут при любых обстоятельствах false будет. Наверное, должна быть , вместо ==
| var image = new Bitmap(Width, Height); | ||
| var g = Graphics.FromImage(image); | ||
| var pen = new Pen(Brushes.AliceBlue, 2); | ||
| var count = 0; |
| using TagsCloudVisualization; | ||
|
|
||
| var random = new Random(); | ||
| var Sizes = new List<Size>(); |
| } | ||
|
|
||
| Sizes = Sizes.OrderByDescending(s => s.Width * s.Height).ToList(); | ||
| var Layouter = new CircularCloudLayouter(new Point(400, 400)); |
| public void PutNextRectangle_RectanglesDoesNotIntersect() | ||
| { | ||
| var Sizes = new List<Size>(); | ||
| for (int i = 10; i < 100; i += 10) |
| { | ||
| public class ImageCreater | ||
| { | ||
| private readonly int Width; |
There was a problem hiding this comment.
Либо это должно быть свойством, либо называться _width / width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.