-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix BusinessService CSV import #766
Conversation
CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application. Fixes: https://issues.redhat.com/browse/MTA-4257 Signed-off-by: Marek Aufart <maufart@redhat.com>
Local testing&reproduces steps: Run Hub
Import first CSV
Import additional CSV
Check app's BusinessServices:
Main without this PR has the last application CSV files are attached to original JIRA ticket (link in description). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application. Fixes: https://issues.redhat.com/browse/MTA-4257 Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application. Fixes: https://issues.redhat.com/browse/MTA-4257 Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application. Fixes: https://issues.redhat.com/browse/MTA-4257 Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Marek Aufart <aufi.cz@gmail.com>
CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application. Fixes: https://issues.redhat.com/browse/MTA-4257 Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: Marek Aufart <maufart@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Marek Aufart <aufi.cz@gmail.com>
CSV importer code used to set the last existing BussinessService to an Application, updating businessService variable from Ref to Value to keep the found BusinessService until it is saved in Application.
Fixes: https://issues.redhat.com/browse/MTA-4257