Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup .gitignore #1951

Merged
merged 1 commit into from
Oct 5, 2024
Merged

cleanup .gitignore #1951

merged 1 commit into from
Oct 5, 2024

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Oct 4, 2024 •
edited by Frenzie
Loading

This change is Reviewable

Frenzie
Frenzie approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, mostly things from the distant past, but I don't know if whoever added .vimrc and .kateconfig will appreciate it. :-P

@NiLuJe
Copy link
Member

NiLuJe commented Oct 4, 2024

Kate was probably me, and IIRC that was mostly for the house rules re: no tabs. I don't remember having had to fight Kate about following the house style for a long time now, and I definitly don't have a local config in there anymore, so, fine by me ;p.

@Frenzie Frenzie merged commit 1623a86 into koreader:master Oct 5, 2024
2 checks passed
@benoit-pierre benoit-pierre deleted the pr/cleanup_gitignore branch October 5, 2024 06:43
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Oct 6, 2024
@benoit-pierre
bump base, macOS edition
7e7f862 
- koreader/koreader-base#1948
- koreader/koreader-base#1949
- koreader/koreader-base#1950
- koreader/koreader-base#1951
- koreader/koreader-base#1952
- koreader/koreader-base#1953
- koreader/koreader-base#1954
- koreader/koreader-base#1955
- koreader/koreader-base#1957
- koreader/koreader-base#1958
@benoit-pierre benoit-pierre mentioned this pull request Oct 6, 2024
Merged
pazos pushed a commit to koreader/koreader that referenced this pull request Oct 6, 2024
@benoit-pierre
bump base, macOS edition (#12605)
db4a07e 
- koreader/koreader-base#1948
- koreader/koreader-base#1949
- koreader/koreader-base#1950
- koreader/koreader-base#1951
- koreader/koreader-base#1952
- koreader/koreader-base#1953
- koreader/koreader-base#1954
- koreader/koreader-base#1955
- koreader/koreader-base#1957
- koreader/koreader-base#1958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @NiLuJe @Frenzie