self sufficient testsuite + macos ci run tests #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We used to do something like that with https://github.com/torch/luajit-rocks btw. (I'm just mentioning it for potential onlookers who might be interested in random historical remarks.) |
|
Random remark about macOS: the last few LuaJIT commits upstream deal with XCode 16 & macOS 15 stupidity, so we might want to bump LuaJIT again, too ;). (Will do so tomorrow if nobody beats me to it, as I'm barely awake rn) |
benoit-pierre
force-pushed
the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
2 times, most recently
from
b2fd244
to
300ca0c
Compare
|
The new macOS job using XCode 16.0 would hang during the build, but pass with the LuaJIT update from #1957, so it clearly has an impact. |
benoit-pierre
force-pushed
the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
5 times, most recently
from
88040a5
to
363d237
Compare
benoit-pierre
force-pushed
the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
from
363d237
to
342bf77
Compare
benoit-pierre
force-pushed
the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
from
342bf77
to
fc6a65b
Compare
benoit-pierre
force-pushed
the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
from
fc6a65b
to
2142b43
Compare
Build & install the testsuite dependencies ourselves.
No need to install jq (already provided by the runner image).
Even when building for the `macos` target, so tests can be run.
``` Error: The `brew link` step did not complete successfully The formula built, but is not symlinked into /opt/homebrew Could not symlink bin/pkg-config Target /opt/homebrew/bin/pkg-config is a symlink belonging to pkg-config@0.29.2. You can unlink it: brew unlink pkg-config@0.29.2 To force the link and overwrite all conflicting files: brew link --overwrite pkgconf To list all files that would be deleted: brew link --overwrite pkgconf --dry-run Possible conflicting files are: /opt/homebrew/bin/pkg-config -> /opt/homebrew/Cellar/pkg-config@0.29.2/0.29.2_3/bin/pkg-config /opt/homebrew/share/aclocal/pkg.m4 -> /opt/homebrew/Cellar/pkg-config@0.29.2/0.29.2_3/share/aclocal/pkg.m4 /opt/homebrew/share/man/man1/pkg-config.1 -> /opt/homebrew/Cellar/pkg-config@0.29.2/0.29.2_3/share/man/man1/pkg-config.1 ``` This only happen with AMD64 runners, and when using the latest runner images (e.g. when the luck of the draw yields 14.7.1 23H222 and not 14.7 23H124).
benoit-pierre
force-pushed
the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
from
2142b43
to
853dd8c
Compare
benoit-pierre
deleted the
pr/self-sufficient_testsuite_+_macos_ci_run_tests
branch
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Nov 21, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to run the tests on the macOS CI, but then I remembered lua5.1 is not supported by brew anymore, and figured I might as well make our testsuite self-sufficient (like with the meson branch): install luarocks to staging and the necessary Lua packages to a dedicated tree under the output
specdirectory.This led to discovering 2 macOS specific issues: see #1953 & #1954.
This change is