tests: install luacov & cluacov to spec tree #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Nov 22, 2024
|
Random PR picked maybe (although it mentions luacov which is in my output below too), just to mention that when attempting to re kodev build, some luarock stuff (I think) do get rebuilt each time: (I also got tesseract rebuilt, while I remember it did get built last time I synbed 3 days ago.) |
|
Well, the tesseract update was bumped to master only 32 hours ago, same with the luarocks stuff. You get the same output every time? |
What I pasted above: yes. |
|
You can try running |
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Nov 22, 2024
|
It doesnt really explain anything to me :) |
|
Can you attach the full output? |
|
Sure: explain.txt |
|
And remind me your cmake version? |
|
And ninja version. |
|
|
I can reproduce with cmake 3.25.1. |
|
Can you confirm #1986 fix your issue? You'll have to rebuild those external projects from scratch after applying the fix: |
|
^ Following your procedure, it's all fine - after it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix coverage on master (https://app.circleci.com/pipelines/github/koreader/koreader/11659/workflows/527da8a7-fe87-4125-8656-dd1a707a2a9e/jobs/17231). The addition of cluacov (which must be compiled for the luajit version used during coverage, or things go boom) also greatly speeds up things (see https://app.circleci.com/pipelines/github/benoit-pierre/koreader/528/workflows/59965b76-8cfa-4e07-a75e-454aefc6c088/jobs/547).
This change is