New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate fetcher interface #11

Merged

koron merged 1 commit into main from opt-deprecate-fetcher-interface

Apr 18, 2024

Contributor

koron commented Apr 17, 2024 •

edited

Loading

Removing the fetcher interface (use fetch function directly) makes function calls faster at fetching opcodes.

make profile test (make -C cmd/zexdoc profile) faster about 3~4%


          deprecate fetcher interface

d449715

koron marked this pull request as ready for review

April 18, 2024 00:28

koron merged commit 79b5239 into main

3 checks passed

Contributor Author

koron commented Apr 18, 2024

In any case, this change will speed up the emulator, so adopt it.

koron deleted the opt-deprecate-fetcher-interface branch

April 18, 2024 00:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet