Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Visual regression tests #303

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gustaphe
Copy link
Collaborator

@gustaphe gustaphe commented Aug 8, 2024

An idea to solve #78 , using VisualRegressionTests.jl
Not ready or even sure if it's that useful, but I wanted to see if I could get CI to collaborate.

Also needed an option to render without transparency, which should probably be implemented either way.

@gustaphe gustaphe force-pushed the visualregressiontests branch from 0aa4706 to 93e2c2b Compare August 8, 2024 15:08
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (4a3e41b) to head (3d2d8ca).
Report is 9 commits behind head on master.

Files Patch % Lines
src/utils.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   82.87%   82.89%   +0.02%     
==========================================
  Files          21       22       +1     
  Lines         905      912       +7     
==========================================
+ Hits          750      756       +6     
- Misses        155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gustaphe
Copy link
Collaborator Author

gustaphe commented Aug 9, 2024

There we go. We could probably come back to this before we make any big changes (like #161)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant