Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to pyproject.toml #110

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Conversation

branchvincent
Copy link
Contributor

Fixes #109

The project fails to install with modern versions of pip due to pep 517 build isolation (setup.py imports from sail)

This migrates to pyproject.toml, replacing setup.py, requirements.txt, MANIFEST.in (flit automatically includes all data files under sail)

As shown with `python3.12 -m compileall -f $(git ls-files '*.py')`
@kovshenin
Copy link
Owner

Thanks @branchvincent, I had no idea this existed! I guess I'll need to update Dependabot now that requirements.txt is gone.

@kovshenin kovshenin merged commit 76ff2c7 into kovshenin:main Apr 20, 2024
1 check passed
@branchvincent
Copy link
Contributor Author

Thanks! I think your existing Dependabot config should still work

@branchvincent branchvincent deleted the pyproject.toml branch April 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sailed.io 0.10.8 regression build failure
2 participants