fix support for read of 3D images with unnormalised sampler #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjodinchr
force-pushed
the
dev/sampler-arg
branch
2 times, most recently
from
5ecd83c
to
f07fe59
Compare
alan-baker
reviewed
Sep 20, 2023
kpet
requested changes
Oct 11, 2023
| @@ -237,7 +245,8 @@ struct cvk_kernel_argument_values { | |||
| } | |||
|
|
|||
| if (m_entry_point->has_pod_arguments() || | |||
| m_entry_point->has_image_metadata()) { | |||
| m_entry_point->has_image_metadata() || | |||
| m_entry_point->has_sampler_metadata()) { | |||
There was a problem hiding this comment.
It's really time we refactor push constant management to make it more readable. In a lot of places, they're still named "POD". Best done as a standalone changes.
| sizeof(uint32_t) - | ||
| push_constant_range.offset; | ||
| push_constant_range.size = | ||
| offset + sizeof(uint32_t) - push_constant_range.offset; |
There was a problem hiding this comment.
This code is now screaming "refactor me" :). To be done as a standalone change.
rjodinchr
force-pushed
the
dev/sampler-arg
branch
from
f07fe59
to
4d5f8d1
Compare
Set the sampler mask in the push constant, but also create a new sampler with normalised coordinate if not already the case or already created.
rjodinchr
force-pushed
the
dev/sampler-arg
branch
from
4d5f8d1
to
d707806
Compare
|
This PR will need to have clspv and spirv-headers updated to go it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on google/clspv#1234
We parse the new NormalizedSamplerMaskPushConstant non-semantic instruction from KhronosGroup/SPIRV-Headers#377.
Set the sampler mask in the push constant, but also create a new sampler with normalised coordinate if not already the case or already created.