Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init image at creation time #720

Merged
merged 1 commit into from
Nov 11, 2024
Merged

init image at creation time #720

merged 1 commit into from
Nov 11, 2024

Conversation

rjodinchr
Copy link
Contributor

fix #719

kpet
kpet requested changes Nov 6, 2024
View reviewed changes
Copy link
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fine with this being an option. Please add a unit test.

src/queue.cpp Outdated Show resolved Hide resolved
src/context.cpp Show resolved Hide resolved
src/context.hpp Show resolved Hide resolved
@rjodinchr rjodinchr force-pushed the pr/init-image branch 2 times, most recently from 4be5e5d to e041920 Compare November 7, 2024 08:20
@rjodinchr rjodinchr requested a review from kpet November 7, 2024 08:21
@rjodinchr rjodinchr force-pushed the pr/init-image branch 4 times, most recently from 2531142 to fcd53d7 Compare November 7, 2024 15:51
kpet
kpet reviewed Nov 10, 2024
View reviewed changes
src/context.hpp Show resolved Hide resolved
src/queue.hpp Outdated Show resolved Hide resolved
src/queue.cpp Outdated Show resolved Hide resolved
@rjodinchr rjodinchr mentioned this pull request Nov 10, 2024
Open
@rjodinchr rjodinchr requested a review from kpet November 10, 2024 16:22
kpet
kpet approved these changes Nov 11, 2024
View reviewed changes
Copy link
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kpet kpet merged commit 0ec42cc into kpet:main Nov 11, 2024
9 checks passed
@rjodinchr rjodinchr deleted the pr/init-image branch November 12, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image init data buffer
2 participants
@rjodinchr @kpet