Implementation of Command Pattern in the TreeList Class #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes an improvement to the TreeList class by implementing the Command pattern. Currently, the TreeList class has multiple responsibilities, including receiving user input and executing corresponding actions based on that input. This leads to a high degree of coupling. To address these issues, this improvement suggests moving the user action methods from the TreeList class to concrete Command classes that inherit from the Abstract Command interface. The handle_key method in TreeList will no longer directly execute the actions but instead call an Invoker, which will receive and execute the command. This decouples the user actions from the TreeList class and promotes better separation of concerns.
Current design:
Design proposed in the PR:
