Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.3 #206

Closed
wants to merge 1 commit into from
Closed

Allow PHP 8.3 #206

wants to merge 1 commit into from

Conversation

L3o-pold
Copy link
Contributor

@L3o-pold L3o-pold commented Nov 27, 2023 •
edited
Loading

Description

Allow PHP 8.3 and drop PHP 8.1

Wait for kreait/firebase-php#847

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation

@L3o-pold L3o-pold marked this pull request as draft November 27, 2023 22:38
@jeromegamez jeromegamez mentioned this pull request Nov 30, 2023
Closed
@ankurk91
Copy link
Contributor

ankurk91 commented Dec 1, 2023

There is no need to drop support for php 8.1.
@jeromegamez

@jeromegamez
Copy link
Member

Merged with 7cd191a, thank you @L3o-pold!

@jeromegamez jeromegamez closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@L3o-pold @ankurk91 @jeromegamez