fix: use alternative oxi binding to get filetype #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution works, but is quite hacky. It doesn't seem to break the api for end users though, and currently works on nightly. It likely works on 0.8 as well.
Instead of causing an immediate panic when a filetype can't be found, instead boil an error up for user presentation stating a filetype isn't found. This ensures Neovim doesn't just up and die when a panic occurs.
|
Tested on |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution works, but is quite hacky. It doesn't seem to break the api for end users though, and currently works on nightly. It likely works on 0.8 as well.
This closes #26 for now. Once
nvim-oxigets updated this hack around should be replaced with what was previously there.This should also close #10.
I have only tested against nightly, it would be wise to also test this against
0.8, as this may end up being a breaking change for older neovim builds (though I doubt it, it calls directly into VimL).