cppcheck: Suppress a few false positives from cppcheck 2.14

krivenko · Jul 16, 2024 · 1689c86 · 1689c86
1 parent 9b829c0
commit 1689c86
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/include/libcommute/expression/dyn_indices.hpp b/include/libcommute/expression/dyn_indices.hpp
@@ -98,6 +98,7 @@ template <typename... IndexTypes> class dyn_indices_generic {
   }
 
   // Reference to underlying sequence
+  // cppcheck-suppress returnByReference
   explicit operator indices_t const&() const { return indices_; }
 
   // Stream output

diff --git a/include/libcommute/utility.hpp b/include/libcommute/utility.hpp
@@ -131,9 +131,11 @@ template <> struct print_tuple_impl<0> {
 } // namespace detail
 
 template <typename... T>
+// cppcheck-suppress constParameterReference
 inline void print_tuple(std::ostream& os, std::tuple<T...> const& t) {
   detail::print_tuple_impl<sizeof...(T) - 1>::apply(os, t);
 }
+// cppcheck-suppress constParameterReference
 inline void print_tuple(std::ostream& os, std::tuple<> const& t) {}
 
 //

diff --git a/test/monomial_action.cpp b/test/monomial_action.cpp
@@ -170,8 +170,8 @@ TEST_CASE("Action of a mixed monomial", "[monomial_action]") {
         static std::vector<bit_range_t> bit_ranges = {{2, 3}, {4, 5}};
 
         auto const& bit_range = bit_ranges[ind];
-        int n_bits = bit_range.second - bit_range.first + 1;
-        int n_max = (1 << n_bits) - 1;
+        int const n_bits = bit_range.second - bit_range.first + 1;
+        int const n_max = (1 << n_bits) - 1;
 
         std::bitset<total_n_bits> in_bitset(index);
 

diff --git a/test/monomial_action_boson.cpp b/test/monomial_action_boson.cpp
@@ -66,8 +66,8 @@ TEST_CASE("Action of a bosonic monomial on an index",
         bool dagger = dynamic_cast<generator_boson<int> const&>(g).dagger();
 
         auto const& bit_range = bit_ranges[ind];
-        int n_bits = bit_range.second - bit_range.first + 1;
-        int n_max = (1 << n_bits) - 1;
+        int const n_bits = bit_range.second - bit_range.first + 1;
+        int const n_max = (1 << n_bits) - 1;
 
         std::bitset<total_n_bits> in_bitset(index);