-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Renaissance Benchmark #51
Draft
Prakalp23
wants to merge
77
commits into
kruize:master
Choose a base branch
from
Prakalp23:renaissance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issance-cleanup.sh
chandrams
reviewed
Sep 9, 2022
chandrams
reviewed
Sep 9, 2022
chandrams
reviewed
Sep 9, 2022
Prakalp23
requested review from
chandrams and
kusumachalasani
and removed request for
chandrams
September 10, 2022 07:08
chandrams
reviewed
Sep 12, 2022
Prakalp23
force-pushed
the
renaissance
branch
from
September 12, 2022 11:24
d0f73ed
to
35dcef3
Compare
chandrams
reviewed
Sep 13, 2022
|-------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| perf/getmetrics-promql.sh | Has prometheus queries that are required calculate the metrics required for objective function and the benchmark. | | ||
| perf/parsemetrics-promql.sh | Parse the prometheus metrics data to calculate the average , max and min values as per the requirement of the benchmark. | | ||
| perf/ci.php | Use to measure confidence interval of data. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing, can you include this file.
| perf/getmetrics-promql.sh | Has prometheus queries that are required calculate the metrics required for objective function and the benchmark. | | ||
| perf/parsemetrics-promql.sh | Parse the prometheus metrics data to calculate the average , max and min values as per the requirement of the benchmark. | | ||
| perf/ci.php | Use to measure confidence interval of data. | | ||
| perf/parsemetrics-wrk.sh | Parse the metrics data from hyperfoil/wrk load simulator. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been removed now, can you update the readme as well. Also add details about other scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.