Add support for 'KIND' tool #81

khansaad · 2024-06-11T04:49:23Z

Add support for `Kind` tool in case of Local monitoring

Description

This PR will do the following changes -

update the helper files and local monitoring demo script to support Kind instead of Minikube.

Type of change

Refactoring Code
New feature

How has this been tested?

In Progress.

Test Configuration

Kubernetes clusters tested on: Kind

Checklist 🎯

Additional information

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad · 2024-06-12T12:47:53Z

Note: Need to merge the PR 1207 first as it contains the script to install prometheus on kind.

For testing, please take the file from that PR and put it in the scripts directory before running the demo.

msvinaykumar · 2024-06-13T11:04:24Z

common/common_helper.sh

+###########################################
+# Check if kind is installed
+###########################################
+function check_kind() {


If check_kind fails to find Kind then Ask a prompt to install if yes then install

As discussed, since this will require sudo permissions, we won't be giving the option to the user to automatically install it.

chandrams · 2024-06-14T05:10:12Z

common/common_helper.sh

+function check_kind() {
+ if ! which kind >/dev/null 2>/dev/null; then
+ echo "ERROR: Please install kind and try again"
+ print_min_resources


Are the resource requirements same? Update the message in print_min_resources with cluster_type

Yes, we're keeping it the same as minikube.
Updated the message now to make it cluster_type specific.

Signed-off-by: Saad Khan <saakhan@redhat.com>

chandrams · 2024-06-18T06:04:47Z

@khansaad - As discussed, please check if the below issue is seen:

Error: Port 8080 is already in use. Port forwarding for kruize service cannot be established.
Error: Port 8081 is already in use. Port forwarding for kruize-ui-nginx-service cannot be established.
Error: Port 8082 is already in use. Port forwarding for tfb-service cannot be established.
######################################################
#     Listing all datsources known to Kruize
######################################################
Handling connection for 8080
E0614 13:06:56.352450 1608387 portforward.go:409] an error occurred forwarding 8080 -> 8080: error forwarding port 8080 to pod 3b01f05d5b338612c00bfbd4c77aa5690b8a6a58641750864b47a4afe422d68e, uid : failed to find sandbox "3b01f05d5b338612c00bfbd4c77aa5690b8a6a58641750864b47a4afe422d68e" in store: not found
curl: (52) Empty reply from server
error: lost connection to pod
######################################################
#     Import metadata from prometheus-1 datasource
######################################################
curl: (7) Failed to connect to 127.0.0.1 port 8080 after 0 ms: Couldn't connect to server

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad · 2024-06-18T12:25:25Z

@khansaad - As discussed, please check if the below issue is seen:

Error: Port 8080 is already in use. Port forwarding for kruize service cannot be established.
Error: Port 8081 is already in use. Port forwarding for kruize-ui-nginx-service cannot be established.
Error: Port 8082 is already in use. Port forwarding for tfb-service cannot be established.
######################################################
#     Listing all datsources known to Kruize
######################################################
Handling connection for 8080
E0614 13:06:56.352450 1608387 portforward.go:409] an error occurred forwarding 8080 -> 8080: error forwarding port 8080 to pod 3b01f05d5b338612c00bfbd4c77aa5690b8a6a58641750864b47a4afe422d68e, uid : failed to find sandbox "3b01f05d5b338612c00bfbd4c77aa5690b8a6a58641750864b47a4afe422d68e" in store: not found
curl: (52) Empty reply from server
error: lost connection to pod
######################################################
#     Import metadata from prometheus-1 datasource
######################################################
curl: (7) Failed to connect to 127.0.0.1 port 8080 after 0 ms: Couldn't connect to server

Added the check for the same and exit the demo if port is unavailable.

chandrams · 2024-06-26T07:34:29Z

@khansaad - I 'm not seeing cpu recommendations with kind too, can you please check

  "recommendation_engines": {
                        "cost": {
                          "pods_count": 0,
                          "confidence_level": 0.0,
                          "config": {
                            "requests": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            },
                            "limits": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            }
                          },
                          "variation": {
                            "requests": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            },
                            "limits": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            }
                          },

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad · 2024-07-02T06:09:19Z

@khansaad - I 'm not seeing cpu recommendations with kind too, can you please check

  "recommendation_engines": {
                        "cost": {
                          "pods_count": 0,
                          "confidence_level": 0.0,
                          "config": {
                            "requests": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            },
                            "limits": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            }
                          },
                          "variation": {
                            "requests": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            },
                            "limits": {
                              "memory": {
                                "amount": 2.586329088E8,
                                "format": "bytes"
                              }
                            }
                          },

Fixed now. Attached the latest response JSON
kind-demo-run-response.json

Signed-off-by: Saad Khan <saakhan@redhat.com>

chandrams · 2024-07-03T12:05:40Z

@khansaad I 'm getting this error with prometheus install using v0.13.0, is there anything I 'm missing out here?

servicemonitor.monitoring.coreos.com/prometheus-k8s serverside-applied
resource mapping not found for name: "alertmanager-main" namespace: "monitoring" from "alertmanager-podDisruptionBudget.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
ensure CRDs are installed first
resource mapping not found for name: "prometheus-k8s" namespace: "monitoring" from "prometheus-podDisruptionBudget.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
ensure CRDs are installed first
Error: Unable to install prometheus
ERROR: Prometheus failed to start, exiting

Kubectl version

kubectl version
Client Version: v1.28.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.0

khansaad · 2024-07-03T13:58:03Z

@khansaad I 'm getting this error with prometheus install using v0.13.0, is there anything I 'm missing out here?


servicemonitor.monitoring.coreos.com/prometheus-k8s serverside-applied

resource mapping not found for name: "alertmanager-main" namespace: "monitoring" from "alertmanager-podDisruptionBudget.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"

ensure CRDs are installed first

resource mapping not found for name: "prometheus-k8s" namespace: "monitoring" from "prometheus-podDisruptionBudget.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"

ensure CRDs are installed first

Error: Unable to install prometheus

ERROR: Prometheus failed to start, exiting

Kubectl version


kubectl version

Client Version: v1.28.0

Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

Server Version: v1.28.0

Please confirm that minikube isn't running as well. Try stopping/deleting minikube once and run the demo again.

chandrams · 2024-07-04T04:48:06Z

@khansaad minikube is not running, I had deleted it before trying this script

Signed-off-by: Saad Khan <saakhan@redhat.com>

chandrams · 2024-07-05T12:08:46Z

Finally got it working by deleting kind_downloads, thanks @khansaad

chandrams

LGTM

# Conflicts: # monitoring/local_monitoring/local_monitoring_demo.sh

updates wrt kind

ec45356

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad added the enhancement New feature or request label Jun 11, 2024

khansaad requested review from chandrams and msvinaykumar June 11, 2024 04:49

khansaad self-assigned this Jun 11, 2024

fix the URLs to access the endpoints

4ae6ea9

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad marked this pull request as ready for review June 12, 2024 08:24

khansaad mentioned this pull request Jun 12, 2024

Add new script to install Prometheus on Kind kruize/autotune#1207

Open

7 tasks

msvinaykumar reviewed Jun 13, 2024

View reviewed changes

chandrams reviewed Jun 14, 2024

View reviewed changes

update message while checking resources for cluster

36f1e98

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad requested a review from chandrams June 14, 2024 12:35

exit the demo if port is unavailable

894b082

Signed-off-by: Saad Khan <saakhan@redhat.com>

khansaad added 3 commits July 1, 2024 15:21

update versions, hide port-forward output

59051e5

Signed-off-by: Saad Khan <saakhan@redhat.com>

Merge remote-tracking branch 'upstream/main'

295c978

refactor code to fix the port-forwarding failures post rebase

0c38f5c

Signed-off-by: Saad Khan <saakhan@redhat.com>

revert changes to support both kind and minikube

e5c6f47

Signed-off-by: Saad Khan <saakhan@redhat.com>

update ReadMe

ec9b23c

Signed-off-by: Saad Khan <saakhan@redhat.com>

chandrams approved these changes Jul 5, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main'

3e5796f

# Conflicts: # monitoring/local_monitoring/local_monitoring_demo.sh

rbadagandi1 added the remote_monitoring label Jul 10, 2024

rbadagandi1 added this to the Kruize 0.0.24_rm Release milestone Jul 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for 'KIND' tool #81

Add support for 'KIND' tool #81

khansaad commented Jun 11, 2024 •

edited

Loading

khansaad commented Jun 12, 2024

msvinaykumar Jun 13, 2024

khansaad Jun 14, 2024

chandrams Jun 14, 2024

khansaad Jun 14, 2024

chandrams commented Jun 18, 2024

khansaad commented Jun 18, 2024

chandrams commented Jun 26, 2024

khansaad commented Jul 2, 2024

chandrams commented Jul 3, 2024

khansaad commented Jul 3, 2024

chandrams commented Jul 4, 2024

chandrams commented Jul 5, 2024

chandrams left a comment

Add support for 'KIND' tool #81

Are you sure you want to change the base?

Add support for 'KIND' tool #81

Conversation

khansaad commented Jun 11, 2024 • edited Loading

Add support for Kind tool in case of Local monitoring

Description

Type of change

How has this been tested?

Checklist 🎯

Additional information

khansaad commented Jun 12, 2024

msvinaykumar Jun 13, 2024

Choose a reason for hiding this comment

khansaad Jun 14, 2024

Choose a reason for hiding this comment

chandrams Jun 14, 2024

Choose a reason for hiding this comment

khansaad Jun 14, 2024

Choose a reason for hiding this comment

chandrams commented Jun 18, 2024

khansaad commented Jun 18, 2024

chandrams commented Jun 26, 2024

khansaad commented Jul 2, 2024

chandrams commented Jul 3, 2024

khansaad commented Jul 3, 2024

chandrams commented Jul 4, 2024

chandrams commented Jul 5, 2024

chandrams left a comment

Choose a reason for hiding this comment

khansaad commented Jun 11, 2024 •

edited

Loading

Add support for `Kind` tool in case of Local monitoring