Support for dualstack loadbalancer services #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Xie <exie@vmware.com>
Signed-off-by: Edwin Xie <exie@vmware.com>
lubronzhan
reviewed
Dec 20, 2023
| if len(secondaryPool) > 0 { | ||
| secondaryVip, err := discoverAddress(namespace, secondaryPool, inUseIPSet, descOrder) | ||
| if err != nil { | ||
| return "", err |
There was a problem hiding this comment.
Right now if there is not enough ip in the pool, discoverAddress will return error.
Maybe we can make that error a constant, and check here if it's out of IP for secondaryPool and it's preferedDualstack for ipfamilyPolicy, still continue with a warning
There was a problem hiding this comment.
I've added some handling for this case. Hopefully the changes address all these concerns.
|
Nice thought on using the |
Signed-off-by: Edwin Xie <exie@vmware.com>
Signed-off-by: Edwin Xie <exie@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-on to kube-vip/kube-vip#687, I've decided to implement handling for dualstack loadbalancer services in kube-vip-cloud-provider by making the following changes:
kube-vip.io/loadbalancerIPsmay now contain multiple comma-separated IP addresses. This may be a breaking change without the PR from aboveAny comments or concerns welcome!