Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gpio mappers for huawei atlas200DKOrsline merge #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

orsline
Copy link

@orsline orsline commented Feb 16, 2023

add gpio mappers for huawei atlas200DK

The image cache is applied in the lib library for transferring images, which needs to be released, otherwise there will be a memory leak
2.Modify data update strategy
When the device's desire value is inconsistent with the report value, edgecore will re-deliver the desire value. This judgment will cause the desire value to fail to be delivered, because the desire value saved by the mapper has not changed.

Signed-off-by: zhangyanhua <zhangyanhua@huawei.com>
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 16, 2023
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2023
@RyanZhaoXB
Copy link
Collaborator

please fix go lint and fix the make[1]: *** No rule to make target 'mapper'. Stop. error in https://github.com/kubeedge/mappers-go/actions/runs/4201433968/jobs/7450881353.
re-push the commit and re-run the CI workflow.

@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 14, 2023
@orsline orsline force-pushed the orsline-merge branch 3 times, most recently from a8a5e89 to bd34b5f Compare March 20, 2023 07:07
Signed-off-by: zhangyanhua <zhangyanhua@huawei.com>
@@ -293,6 +293,7 @@ func (gigEClient *GigEVisionDevice) PostImage(DeviceSN string) {
go func() {
var buffer []byte
var bufferHdr = (*reflect.SliceHeader)(unsafe.Pointer(&buffer))
defer C.free_image((**C.char)(unsafe.Pointer(&imageBuffer)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This func can free the memory after the func ends and avoid the problem of memory leak

WORKDIR /usr/local/bin
COPY ./res /usr/local/res
COPY ./bin /usr/local/bin
#RUN echo "HwHiAiUser:x:1000:1000::/home/HwHiAiUser:" >> /etc/passwd ; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'HwHiAiUser’ used for atlas200DK?

- edge-a200-00 #pls give your edge node name
propertyVisitors:
- propertyName: red-power-status
collectCycle: 10000000000 #Mapper 从设备收集数据的频率
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the comment in English

@@ -0,0 +1,20 @@
-----BEGIN CERTIFICATE-----
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure if we should provide the .crt and .key file here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants