-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk/backend): add data_source parameter to PVC creation #11439
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @leseb. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The kpf.kubernetes SDK now supports creating PVC from a data source. This feature would enable users to create PVCs with pre-populated data, aligning with Kubernetes capabilities for cloning or restoring PVCs from existing volumes or snapshots. This is how it can be done: ```python pvc = kfp.Kubernetes.CreatePVC( pvc_name_suffix="-foo", access_modes=["ReadWriteOnce"], size="100Gi", data_source={"api_group": "snapshot.storage.k8s.io", "kind": "VolumeSnapshot", "name": "my-snap", }, ) ``` Resolves: kubeflow#11420 Signed-off-by: Sébastien Han <seb@redhat.com>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of your changes:
28420e2 feat(sdk/backend): add data_source parameter to PVC creation
commit 28420e2
Author: Sébastien Han seb@redhat.com
Date: Wed Dec 4 15:28:27 2024 +0100
Checklist:
Resolves #11420