Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): request task logs only if pod was created #11458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −9
Open

fix(ui): request task logs only if pod was created #11458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions frontend/src/components/tabs/RuntimeNodeDetailsV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,15 +321,17 @@ async function getLogsInfo(execution: Execution, runId?: string): Promise<Map<st
return logsInfo; // Early return if it is from cache.
}

try {
logsDetails = await Apis.getPodLogs(runId!, podName, podNameSpace, createdAt);
logsInfo.set(LOGS_DETAILS, logsDetails);
} catch (err) {
let errMsg = await errorToMessage(err);
logsBannerMessage = 'Failed to retrieve pod logs.';
logsInfo.set(LOGS_BANNER_MESSAGE, logsBannerMessage);
logsBannerAdditionalInfo = 'Error response: ' + errMsg;
logsInfo.set(LOGS_BANNER_ADDITIONAL_INFO, logsBannerAdditionalInfo);
if (podName && podName !== '') {
try {
logsDetails = await Apis.getPodLogs(runId!, podName, podNameSpace, createdAt);
logsInfo.set(LOGS_DETAILS, logsDetails);
} catch (err) {
let errMsg = await errorToMessage(err);
logsBannerMessage = 'Failed to retrieve pod logs.';
logsInfo.set(LOGS_BANNER_MESSAGE, logsBannerMessage);
logsBannerAdditionalInfo = 'Error response: ' + errMsg;
logsInfo.set(LOGS_BANNER_ADDITIONAL_INFO, logsBannerAdditionalInfo);
}
}
return logsInfo;
}
Expand Down
Loading