-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release branch to the image push trigger #2376
Add release branch to the image push trigger #2376
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nice job @andreyvelich ! And just a question. Shall we add the release branch to the UT/e2e tests trigger? Is it safe enough not to test the release branch?
I guess, we run our UT and E2E on all branches already, isn't @Electronic-Waste ? |
Pull Request Test Coverage Report for Build 12654542847Details
💛 - Coveralls |
@andreyvelich Thanks for the clarification. LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.9 |
@andreyvelich: new pull request created: #2377 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since we decided to use
release-
branch, we need to update the image push trigger in our CI./assign @kubeflow/wg-training-leads