Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release branch to the image push trigger #2376

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

andreyvelich
Copy link
Member

Since we decided to use release- branch, we need to update the image push trigger in our CI.

/assign @kubeflow/wg-training-leads

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member Author

cc @Electronic-Waste

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice job @andreyvelich ! And just a question. Shall we add the release branch to the UT/e2e tests trigger? Is it safe enough not to test the release branch?

@andreyvelich
Copy link
Member Author

Shall we add the release branch to the UT/e2e tests trigger? Is it safe enough not to test the release branch?

I guess, we run our UT and E2E on all branches already, isn't @Electronic-Waste ?
https://github.com/kubeflow/training-operator/blob/master/.github/workflows/integration-tests.yaml#L68

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12654542847

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12643949527: 0.0%
Covered Lines: 85
Relevant Lines: 85

💛 - Coveralls

@Electronic-Waste
Copy link
Member

@andreyvelich Thanks for the clarification. LGTM!

Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 25c760c into kubeflow:master Jan 7, 2025
55 checks passed
@andreyvelich andreyvelich deleted the fix-ci-push-branch branch January 7, 2025 17:27
@andreyvelich
Copy link
Member Author

/cherry-pick release-1.9

@google-oss-robot
Copy link

@andreyvelich: new pull request created: #2377

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants