do not set gatewayType for non ovn subnet and custom vpc subnet #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
oilbeater
force-pushed
the
chore/format-subnet
branch
from
67e3bae
to
7d0ee75
Compare
bobz965
approved these changes
Jul 12, 2024
|
Hi @oilbeater , is custom ovn vpc subnet gatewayType always be |
In fact gatewayType only works for default VPC. For custom VPC we can only config vpc-nat-gateway and routes |
ok, I got it. so In custom vpc, user can choose vpc-nat-gw (centralized) or ovn dnat snat (centralized), ovn fip can choose (centralized or distributed) |
SkalaNetworks
pushed a commit
to SkalaNetworks/kube-ovn
that referenced
this pull request
Jul 12, 2024
…ovn#4283) Signed-off-by: oilbeater <liumengxinfly@gmail.com>
SkalaNetworks
pushed a commit
to SkalaNetworks/kube-ovn
that referenced
this pull request
Jul 12, 2024
…ovn#4283) Signed-off-by: oilbeater <liumengxinfly@gmail.com>
bobz965
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: oilbeater <liumengxinfly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)