Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboards): Graph mem usage w and w/o cache #1001

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(dashboards): Graph mem usage w and w/o cache #1001

merged 1 commit into from
Dec 17, 2024

Conversation

skl
Copy link
Collaborator

@skl skl commented Dec 16, 2024

Fixes #999

Changes:

  • Fixed incorrect panel title
  • We now have two memory charts on the node (pods) dashboard, one with cache and one without
Screenshot 2024-12-16 at 18 07 52

@skl skl added the bug Something isn't working label Dec 16, 2024
@skl skl self-assigned this Dec 16, 2024
@skl skl requested a review from povilasv as a code owner December 16, 2024 18:12
@skl skl mentioned this pull request Dec 16, 2024
Closed
@skl
Copy link
Collaborator Author

skl commented Dec 16, 2024

FYI lint error is inherited from main:

@dgrieser
Copy link

Fixes #999

Changes:

  • Fixed incorrect panel title
  • We now have two memory charts on the node (pods) dashboard, one with cache and one without
Screenshot 2024-12-16 at 18 07 52

Awesome! Makes me very happy 👏

@skl skl merged commit 13a06e4 into master Dec 17, 2024
16 of 18 checks passed
@skl skl deleted the skl/fix-999-node-mem-usage-charts branch December 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

Assignees

@skl skl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When the title says "Memory Usage (w/o cache)" should it not show RSS?
2 participants
@skl @dgrieser