fix multi-cluster support for windows #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@povilasv did you need assistance here for review? I have multiple windows cluster and I would appreciate the merge here. |
|
Can you folks send a screenshot of before / after? I have no windows clusters so hard to review |
|
Current Dashboard
After Change
The reason is that all recording rules have no cluster label, but the dashboard requires a cluster and put cluster="$cluster" everywhere (which is correct) |
jkroepke
approved these changes
Nov 21, 2023
|
👍 Let's apply the @jkroepke changes |
Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multi-cluster support for windows.