Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for datasource_regex in resources dashboards #870

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Adding support for datasource_regex in resources dashboards #870

merged 1 commit into from
Sep 20, 2023

Conversation

shivam99aa
Copy link

Dashboards created in dashboards/resources does not support datasourceFilterRegex field present in config.libsonnet. This will be resolved with this change.

@povilasv povilasv merged commit baffdc1 into kubernetes-monitoring:master Sep 20, 2023
6 checks passed
@titansmc
Copy link

Hi,
After this PR I am receiving:

10:55 $ jsonnet   -J vendor -m output/dashboards -e '(import "kubernetes-mixin.libsonnet").grafanaDashboards'
RUNTIME ERROR: function has no parameter datasource_regex
	vendor/github.com/kubernetes-monitoring/kubernetes-mixin/dashboards/resources/cluster.libsonnet:(131:7)-(136:8)	object <anonymous>
	vendor/github.com/kubernetes-monitoring/kubernetes-mixin/dashboards/defaults.libsonnet:8:17-44	object <anonymous>
	During manifestation

and it is not clear to what is failing. Could you give me a hint ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv povilasv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivam99aa @titansmc @povilasv