Storage Alerts: Missing cluster label

[jkroepke]

No description provided.

[jkroepke]

@povilasv Why is {{ $labels.%(clusterLabel)s }} an issue here, but here

kubernetes-mixin/alerts/resource_alerts.libsonnet

Line 42 in bcf8426

description: 'Cluster {{ $labels.%(clusterLabel)s }} has overcommitted CPU resource requests for Pods by {{ $value }} CPU shares and cannot tolerate node failure.' % $._config,

is it fine?

[povilasv]

I suggest add some cluster label in tests,

@povilasv Why is {{ $labels.%(clusterLabel)s }} an issue here, but here

kubernetes-mixin/alerts/resource_alerts.libsonnet

Line 42 in bcf8426

description: 'Cluster {{ $labels.%(clusterLabel)s }} has overcommitted CPU resource requests for Pods by {{ $value }} CPU shares and cannot tolerate node failure.' % $._config,

is it fine?

I think due to :

          if $._config.showMultiCluster then {

and tests evaluate different path

[jkroepke]

Looks good now