Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle float apiserver buckets #935

Closed
wants to merge 1 commit into from

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 20, 2024

Depending on the version of client_golang and metrics format (Prometheus vs OpenMetrics), bucket names may contain either integer or float formatting.

Use a regexp match to select either format.

Depending on the version of client_golang and metrics format (Prometheus
vs OpenMetrics), bucket names may contain either integer or float
formatting.

Use a regexp match to select either format.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Contributor Author

SuperQ commented Jul 24, 2024

Ping @povilasv :)

@povilasv
Copy link
Contributor

@SuperQ sorry for delay, given the

kubeApiserverWriteLatency: '1',
is configureable, can't you just configure differently?

I don't really undertand why we need regex here 🤔

@SuperQ
Copy link
Contributor Author

SuperQ commented Jul 31, 2024

A regexp is needed because different versions of K8s produce different le values depending on a few different factors. Since it's somewhat dynamic, using a regexp makes it compatible with different version. I suppose I could put the regexp changes into the default config.

@SuperQ
Copy link
Contributor Author

SuperQ commented Jul 31, 2024

Alternative implementation: #965

@skl
Copy link
Collaborator

skl commented Aug 30, 2024

Suggest we take #965 and close this one.

@povilasv povilasv closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants