Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add issue and pr templates #956

Merged
merged 1 commit into from
Aug 6, 2024
Merged

chore: add issue and pr templates #956

merged 1 commit into from
Aug 6, 2024

Conversation

rexagod
Copy link
Collaborator

@rexagod rexagod commented Jul 17, 2024

povilasv
povilasv reviewed Jul 18, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/enhancements.yaml
description: Propose an enhancement for the existing codebase.
title: '[Enhancement]: '
labels: ['kind/enhancement', 'pending-triage']
body:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add these questions:

"Is your feature request related to a problem? Please describe."
"Describe the solution you'd like"
"Describe alternatives you've considered" (optional)
"Additional context" (optional

@rexagod rexagod force-pushed the templates branch 2 times, most recently from b76352a to 5212b85 Compare July 18, 2024 13:34
@rexagod rexagod requested a review from povilasv July 24, 2024 11:15
@povilasv
Copy link
Contributor

@rexagod did you update the PR with respect to my comments? I don't see any changes 🤔

@rexagod
Copy link
Collaborator Author

rexagod commented Aug 5, 2024 •
edited
Loading

@povilasv Sorry for the delay, I've linked the amends below to make them easier to find.

"Is your feature request related to a problem? Please describe.": https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/956/files#diff-b2c61b52820f561dc45f59a811d5dec6cafcc5bd48f4e1ef060b8709a3337df4R14 (A clear and concise description of the enhancement's targeted problem...)
"Describe the solution you'd like": Same as above (...and its proposed solution)
"Describe alternatives you've considered" (optional) https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/956/files#diff-b2c61b52820f561dc45f59a811d5dec6cafcc5bd48f4e1ef060b8709a3337df4R41 (...if you have considered any alternatives or workarounds, please share them here.)
"Additional context" (optional): https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/956/files#diff-b2c61b52820f561dc45f59a811d5dec6cafcc5bd48f4e1ef060b8709a3337df4R42

Similar reasoning for: #955

@povilasv povilasv merged commit e656535 into kubernetes-monitoring:master Aug 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexagod @povilasv