Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the daemonset rollout stuck alert configurable. #989

Conversation

mplzik
Copy link
Contributor

@mplzik mplzik commented Nov 18, 2024

For bigger Kubernetes clusters with bigger node churn (for instance,
cloud clusters with spot nodes), the daemonset rollouts often get stuck
for longer than just 15 minutes. Since the alert might easily misfire
even in cases where the delay is legitimate.

This PR introduces configurable for value to allow for customization.
As a default, the original value 15m is left, so the only real
difference would be a slight change in the alert message formatting.

Signed-off-by: Milan Plzik milan.plzik@grafana.com

What does this PR fix? Please be as descriptive as possible.**

Any helpful code snippets or visual aids (before and after this patch, if applicable)?**

Details

Fixes #

For bigger Kubernetes clusters with bigger node churn (for instance,
cloud clusters with spot nodes), the daemonset rollouts often get stuck
for longer than just 15 minutes. Since the alert might easily misfire
even in cases where the delay is legitimate.

This PR introduces configurable `for` value to allow for customization.
As a default, the original value `15m` is left, so the only real
difference would be a slight change in the alert message formatting.

Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
@mplzik mplzik requested review from povilasv and skl as code owners November 18, 2024 13:04
Copy link
Collaborator

@skl skl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skl
Copy link
Collaborator

skl commented Nov 19, 2024

@mplzik the lint error is inherited from the master branch, so don't worry about that.

Do you mind fixing the tests, though? Looks like the wording changed from 15 minutes to 15m so need to update the tests to reflect that.

Signed-off-by: Milan Plzik <milan.plzik@grafana.com>
@skl skl merged commit a3fbf21 into kubernetes-monitoring:master Nov 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants