Make crictl events interruptable
#1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
force-pushed
the
events-interruptable
branch
from
07fea38
to
821b30e
Compare
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
We now utilize the new CRI API to make the events method interruptable by the context. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
events-interruptable
branch
from
821b30e
to
e970686
Compare
k8s-ci-robot
added
size/XS
saschagrunert
changed the title
crictl events interruptablecrictl events interruptable
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Ready for review. PTAL @kubernetes-sigs/cri-tools-maintainers |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We now utilize the new CRI API to make the events method interruptable by the context.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
It's
WIPbecause we can wait for a new pinnedcri-{api,client}tag.Does this PR introduce a user-facing change?