Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmox-ubuntu-22.04: Make boot command wait times more robust #1484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tbabej
Copy link

@tbabej tbabej commented Jun 5, 2024

This increases the wait times after pressing Enter key from 5 second to 10 seconds during the boot command insertion, which more results in more robust VM startup process. Previous value of 5 seconds can result in failure due to insufficient wait time:

==> proxmox-iso.ubuntu-2204: Typing the boot command
==> proxmox-iso.ubuntu-2204: Error running boot command:
    Put "https://10.9.1.0:8006/api2/json/nodes/pm0/qemu/104/sendkey": EOF

This increases the wait times after pressing Enter key from 5 second to
10 seconds during the boot command insertion, which more results in more
robust VM startup process. Previous value of 5 seconds can result in
failure due to insufficient wait time:

    ==> proxmox-iso.ubuntu-2204: Typing the boot command
    ==> proxmox-iso.ubuntu-2204: Error running boot command:
        Put "https://10.9.1.0:8006/api2/json/nodes/pm0/qemu/104/sendkey": EOF
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kkeshavamurthy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 5, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @tbabej!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tbabej. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2024
@drew-viles
Copy link
Contributor

Hi @tbabej could you sign the CLA please? We can process this change then - seems sensible to me though!

@mboersma
Copy link
Contributor

@tbabej could you sign the Kubernetes CLA through the link in the comment above? This looks like a simple change we can merge once that is done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants