-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: Allow the configuration of cloud_environment_name #1511
Conversation
|
Welcome @aurel333! |
Hi @aurel333. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I will sign the CLA once all the corporate process is cleared on my side, so it may take a few days |
/ok-to-test |
Hello @mboersma, after some delay due to summer holidays I signed the CLA so the PR can progress. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow the configuration of cloud_environment_name to build images in other Azure clouds
Change description
The variable
cloud_environment_name
was not declared in thepacker.json
file, meaning it was not passed to Packer during the image build resulting in failure in Azure environments different from AzurePublicCloud, such as AzureChinaCloud. By declaring it the configuration can be passed correctly and the image can be built.Related issues
cloud_environment_name
not taken into account #1510