-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU driver enabled Ubuntu(18.04 & 20.04) GCE image #934
Add GPU driver enabled Ubuntu(18.04 & 20.04) GCE image #934
Conversation
Welcome @aniruddha2000! |
Hi @aniruddha2000. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test And until #907 merges: /hold |
fbdb539
to
8822ffb
Compare
cc @codenrhoden for visibility |
/cc @codenrhoden |
4ca1f05
to
4bc21f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
A few minor comments inline. Also, could you update the title and pr description to match the fact that its now 18.04 and 20.04.
@aniruddha2000 are you still working on this? (looks like it is marked as draft/WIP) |
@dims - it’s waiting for #907 to merge. Although we could probably work around this...wdyt @aniruddha2000 @SubhasmitaSw ? |
Yes @dims @richardcase we should go for a workaround |
@@ -1,4 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any make target for Ubuntu 22.04. Is it supported with GPU builds?
Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com> #Add scripts to install drivers in Ubuntu 1804 image
…e existing one Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
d457a7a
to
2a19dc4
Compare
/retest These errors should be fixed now that #1320 merged. |
Thanks @mboersma |
Looks like the tests are passing, @aniruddha2000 there are a few open comments on the PR, could you address them and then I think we can move forward with the PR. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@aniruddha2000 - just checking in to see if you could handle the comments? let me know if can't and i can help out. |
@richardcase can you take this for now? I am bit occupied |
I can, thanks @aniruddha2000 |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
I need to work on this, so: /remove-lifecycle rotten |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/uncc @codenrhoden |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Creates the Ubuntu (18.04 & 20.04) GCE image with GPU drivers pre-installed.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
Waiting for 907 to be merged so that we can be sure about the ssh connection.