[rebased #3360] cluster: drop DisableLocalStorageCapacityIsolation #3651
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
all fedora jobs failed? |
|
There was a flake SSH-ing to the VM in each of them, doesn't seem related. |
|
it never even ran kind in this flake https://github.com/kubernetes-sigs/kind/actions/runs/9457245522/job/26088691929#step:7:22 failed during rootless setup |
|
I'd like all the CI to pass here ideally before merge. I don't think the issue is with these changes though so we should probably debug elsewhere. #648 will run these without changes |
it was used to workaround a kubelet crash issue with rootless providers. The Kubelet seems to work fine now with localStorageCapacityIsolation enabled in a user namespace so drop the special handling. After this change, ephemeral storage can be used in a rootless cluster. Closes: kubernetes-sigs#3359 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
Rebased again after #3653 |
|
All tests passing now. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Rebased #3360, original description below:
it was used to workaround a kubelet crash issue with rootless providers.
The Kubelet seems to work fine now with localStorageCapacityIsolation enabled in a user namespace so drop the special handling. After this change, ephemeral storage can be used in a rootless cluster.
Closes: #3359