node build: Extract version from remote URL #3800
Conversation
At some point changes were made to the structure of the community published tarballs where the expected "version" file is no longer present. This causes the build to fail due to not being able to capture the version of the source being built. Most of the time the requested version is part of the URL for the remote source anyway. This creates a fallback where the version will be extracted from the URL if it cannot be read explicitly from a "version" file in the tarball content. This does not cover the local tarball file path, or if the user points to a non-community published URL. But in the "normal" usage of pointing to community published tarballs, this will prevent the node build from failing in the cases where there is not a version file present. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stmcginnis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
This is likely a bug in the upstream release process and we should open an issue to discuss this with release engineering. |
There was a problem hiding this comment.
This is a breaking change for anyone that was just hosting a tarball at an arbitrary path (versus upstream)
I would really prefer that our release artifacts actually contain the version information in a self-contained way, as a project, and I'm all but certain they did at some point ..
I don't think this is a breaking change. It will still try to read the version from an included "version" file. If that file is not present, and the URL does not contain a version number in the path, there will be no difference in behavior. I.e., it will still fail, or the version file is present and it will work exactly like it did before. Agree we need to root cause the artifact issue, but think this could be useful either way. |
At some point changes were made to the structure of the community published tarballs where the expected "version" file is no longer present. This causes the build to fail due to not being able to capture the version of the source being built.
Most of the time the requested version is part of the URL for the remote source anyway. This creates a fallback where the version will be extracted from the URL if it cannot be read explicitly from a "version" file in the tarball content.
This does not cover the local tarball file path, or if the user points to a non-community published URL. But in the "normal" usage of pointing to community published tarballs, this will prevent the node build from failing in the cases where there is not a version file present.
Closes: #3797