Calico v3.28.[0-1] checksums and change calico default version

[ehsan310]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Calico v3.28.1 checksum and change calico default to 3.27.3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Calico v3.28.0 and v3.28.1 checksum and change calico default version
Update calico apiserver deployment to use new readiness probe 

[k8s-ci-robot]

Hi @ehsan310. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yankay]

/ok-to-test

[ehsan310]

I noticed calico api server health probe is changed, I'll update that as well.

[mzaian]

/ok-to-test

[ehsan310]

@mzaian with this health probe changes do we have to put minimum version for calico ? how do we usually do minimum version ?

[mzaian]

@mzaian with this health probe changes do we have to put minimum version for calico ? how do we usually do minimum version ?

There is no minimum version settings in kubespray. The calico api server is disabled by default see: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L112
If you would like to support previous version(s) you can do an if condition for the readinessProbe configuration.

[ehsan310]

@mzaian it is now conditional on 3.28 version

[ehsan310]

/retest-failed

[ehsan310]

@mzaian something wrong with tests ?

[ehsan310]

/retest-failed

[ant31]

/retest

[ehsan310]

/retest

[ehsan310]

@ant31 @mzaian
New Calico version is release and I am going to raise another PR for 3.28.1 but tests are failing here.

I am not sure if there is anything I can do to fix them ?

[mzaian]

I closed/reopened for the tests. Also FYI: https://github.com/projectcalico/calico/releases/tag/v3.28.1 and I would recommend not setting the default to an earlier release and wait for 1 or 2 more versions.

/cc @yankay @ErikJiang

[ehsan310]

@mzaian all good now ?

[yankay]

HI @cyclinder

Would you please help to review it.

[cyclinder]

Hi @ehsan310 Thanks for the update! It looks good, to better keep constant with the calico upstrem, Can you update the volume type of the calico-node.yaml? see projectcalico/calico@ea7b0b6

[M-JavadHeydarpour]

Hi, I encountered another issue while using Calico v3.27.3. Due to this problem, we also need to consider upgrading to Calico v3.28.1.

Additional Information

For more details, please refer to the related issue: kubernetes-sigs/kubespray#11475.

[mzaian]

Hi, I encountered another issue while using Calico v3.27.3. Due to this problem, we also need to consider upgrading to Calico v3.28.1.

Additional Information

For more details, please refer to the related issue: kubernetes-sigs/kubespray#11475.

Hello @M-JavadHeydarpour
Is this issue fixed in 3.28.X ?? Did you test it?

[mzaian]

Hi, I encountered another issue while using Calico v3.27.3. Due to this problem, we also need to consider upgrading to Calico v3.28.1.

Additional Information

For more details, please refer to the related issue: kubernetes-sigs/kubespray#11475.

Hello @M-JavadHeydarpour Is this issue fixed in 3.28.X ?? Did you test it?

Fixed in v3.28.1 amd v3.27.4 as I checked. I create a PR for release-2.25 #11476

[mzaian]

/retitle Calico v3.28.[0-1] checksums and change calico default version

[mzaian]

/hold
@ehsan310 Please Make v3.28.1 default and reflect that in the readme.

[ehsan310]

/hold @ehsan310 Please Make v3.28.1 default and reflect that in the readme.

Done

[mzaian]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehsan310, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mzaian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ehsan310]

Hi @ehsan310 Thanks for the update! It looks good, to better keep constant with the calico upstrem, Can you update the volume type of the calico-node.yaml? see projectcalico/calico@ea7b0b6

@cyclinder this is done as well.

@mzaian PR is on hold can't be merged.

[mzaian]

/unhold

[ehsan310]

@mzaian just rebased with master , sounds like it needs another approval :)

[ehsan310]

the failed test in not relevant to my changes.

[mzaian]

the failed test in not relevant to my changes.

/lgtm