Add exception for metric component prefixes for object metrics #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/instrumentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
area/developer-guide
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
tariq1890
reviewed
Dec 11, 2020
|
I felt we discussed more than this, but I'm happy to do it piece by piece and decide on each individually (the other two were discussed were library vs component prefix). |
|
/hold |
k8s-ci-robot
added
the
lgtm
Co-authored-by: Tariq Ibrahim <tariq181290@gmail.com>
k8s-ci-robot
removed
the
lgtm
|
/lgtm I believe we have agreement on this. Feel free to remove hold if you agree. |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
This is a follow-up to kubernetes/enhancements#1916, which added kube_* prefixed metrics to the scheduler. The kube_* prefix was first used in Kube-state-metrics, and the linked KEP expanded the use of the prefix beyond a single component.
My primary motivation is to capture the discussions that have been had over the past few months, and make sure that we keep metrics in-line with our naming guidelines.
Some of the related discussion threads:
kubernetes/kubernetes#94866 (comment)
kubernetes/kubernetes#95839 (comment)
kubernetes/enhancements#1916 (comment)
I realized there can be naming collisions if there are controllers for CRDs with the same name, so I added to the prefix of non-built-in resources. Feel free to suggest alternatives.
@kubernetes/sig-instrumentation-api-reviews @smarterclayton