Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd operator working group #7917

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented May 27, 2024

Initial PR to create wg-etcd-operator.

/committee steering

Adding stakeholder SIGs

/sig etcd
/sig cluster-lifecycle

cc @jmhbnz @jberkus @serathius @wenjiaswe @fabriziopandini @hakman @neolit123 @justinsb @vincepri

@k8s-ci-robot k8s-ci-robot added committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jdumars May 27, 2024 15:35
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2024
@ahrtr ahrtr marked this pull request as draft May 27, 2024 15:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@ahrtr ahrtr force-pushed the wg_etcd_operator_20240527 branch 3 times, most recently from 4d94d31 to 8d79f06 Compare May 27, 2024 15:59
@ahrtr
Copy link
Member Author

ahrtr commented May 27, 2024

We need to finalize:

  • liaison
  • day/time for the regular meeting
  • zoom link for the meeting
  • a google doc (archive_url)
  • slack channel
  • mailing list url

sig-list.md Outdated Show resolved Hide resolved
@ahrtr ahrtr force-pushed the wg_etcd_operator_20240527 branch 3 times, most recently from d90e81c to 39a4a74 Compare May 28, 2024 07:05
@ahrtr ahrtr marked this pull request as ready for review May 28, 2024 07:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@ahrtr ahrtr force-pushed the wg_etcd_operator_20240527 branch from 39a4a74 to 4176e7d Compare May 28, 2024 07:27
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggestions.

suggested to replace & with 'and' for more format language.

sigs.yaml Outdated Show resolved Hide resolved
wg-etcd-operator/README.md Outdated Show resolved Hide resolved
wg-etcd-operator/charter.md Outdated Show resolved Hide resolved
wg-etcd-operator/charter.md Outdated Show resolved Hide resolved
wg-etcd-operator/charter.md Outdated Show resolved Hide resolved
@ahrtr ahrtr force-pushed the wg_etcd_operator_20240527 branch from 4176e7d to d0a44a7 Compare May 29, 2024 14:24
@serathius
Copy link
Contributor

LGTM, awesome to see renewed interest into etcd-operator. For me this falls into making "etcd simple to operate" as proposed by the SIG-etcd vision making it a worthy investment.

@ahrtr ahrtr force-pushed the wg_etcd_operator_20240527 branch from d0a44a7 to d9d0301 Compare May 29, 2024 17:19
@ahrtr
Copy link
Member Author

ahrtr commented May 30, 2024

/hold

I am going to send an email "WG-Creation-Request: WG etcd-operator" to dev@kubernetes.io in the following 1~2 weeks.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, thanks for drafting @ahrtr. A few thoughts below.

sig-etcd/README.md Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
wg-etcd-operator/charter.md Show resolved Hide resolved
@neolit123
Copy link
Member

@pacoxu

It would be great if they can at least response to our survey in https://forms.gle/5gBpzaxYtuQPWdBo9.

do you see this as a blocker for the WG etcd operator creation?

@neolit123
Copy link
Member

neolit123 commented Jul 8, 2024

steering committee met on July 3rd but the creation of this WG was not on the agenda.
in terms of the punch card here:
https://github.com/kubernetes/community/blob/master/sig-wg-lifecycle.md#prerequisites-for-a-wg

we are all set with the exception of:

  • steering majority / voting on this ticket
  • sending PR for sigs.yaml in k/community EDIT: nvm, this PR does that.
  • sending email about the sigs.yaml change EDIT: we can just forward the below email

email was already sent to k-dev:
https://groups.google.com/a/kubernetes.io/g/dev/c/L1TgHxIkW_o

@neolit123
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@kvaps
Copy link
Member

kvaps commented Jul 8, 2024

Hey I just wanted to inform that we have weekly comunity meetings for developing aenix-io/etcd-operator, we'll have one of these tomorrow:

When: every Tuesday at 16:00 CET
Where: Google meet
Link to join in:
https://meet.google.com/pib-tpfe-kuv

Minutes:
https://docs.google.com/document/d/1coiWlHOVfPAIyKqtfpYLhq9eeRPHCuuMxmNmVfo9-sA/edit

Everybody is free to join

@soltysh
Copy link
Contributor

soltysh commented Jul 17, 2024

I learnt many projects are using etcd operators for performance issues. A simple solution is using a seperate etcd.

* kyverno has a new project for report server to save reports in a seperate etcd: https://github.com/kyverno/reports-server @realshuting

* Cilium has a solution of using a seperate etcd for all CRDs:  @aanm  https://github.com/cilium/cilium-etcd-operator is archived.

* other scanerios like Events and more. @kvaps has a longer list in [[epic] Move project to Kubernetes-SIGs aenix-io/etcd-operator#73](https://github.com/aenix-io/etcd-operator/issues/73)

Those projects' maintainers and users are potential etcd operator contributors and users.

I believe this point:

Bootstrap a project "etcd-operator" owned by SIG etcd which resides in the etcd-io or kubernetes-sigs Github orgs.
  - Review existing etcd operators to see if any could be forked or referenced to advance the project.

can be considered as covering Paco's comment. I don't think we want to explicitly mention these projects in the charter.

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but mostly looks good, I'll make sure to get a final vote on this topic this week from steering.

wg-etcd-operator/charter.md Show resolved Hide resolved
wg-etcd-operator/charter.md Show resolved Hide resolved
wg-etcd-operator/charter.md Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the wg_etcd_operator_20240527 branch from fc6e7df to 4d84f3b Compare July 17, 2024 11:46
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from steering
/hold
for other members to chime in

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2024
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
[steering]

Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(from steering)

@pacoxu
Copy link
Member

pacoxu commented Jul 17, 2024

/lgtm
/approve
(steering)

@pacoxu It would be great if they can at least response to our survey in https://forms.gle/5gBpzaxYtuQPWdBo9.

do you see this as a blocker for the WG etcd operator creation?

just want to make more cloud native contributors/maintainers/users know this new wg and participate

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, BenTheElder, kvaps, pacoxu, palnabarun, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,pacoxu,palnabarun,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -64,6 +64,7 @@ When the need arises, a [new SIG can be created](sig-wg-lifecycle.md)
|[Batch](wg-batch/README.md)|[batch](https://github.com/kubernetes/kubernetes/labels/wg%2Fbatch)|* Apps<br>* Autoscaling<br>* Node<br>* Scheduling<br>|* [Aldo Culquicondor](https://github.com/alculquicondor), Google<br>* [Marcin Wielgus](https://github.com/mwielgus), Google<br>* [Maciej Szulik](https://github.com/soltysh), Red Hat<br>* [Swati Sehgal](https://github.com/swatisehgal), Red Hat<br>|* [Slack](https://kubernetes.slack.com/messages/wg-batch)<br>* [Mailing List](https://groups.google.com/a/kubernetes.io/g/wg-batch)|* Regular Meeting ([Calendar](https://calendar.google.com/calendar/embed?src=8ulop9k0jfpuo0t7kp8d9ubtj4%40group.calendar.google.com)): [Thursdays (starting February 15th 2024)s at 3PM CET (Central European Time) (monthly)](https://zoom.us/j/98329676612?pwd=c0N2bVV1aTh2VzltckdXSitaZXBKQT09)<br>* Regular Meeting ([Calendar](https://calendar.google.com/calendar/embed?src=8ulop9k0jfpuo0t7kp8d9ubtj4%40group.calendar.google.com)): [Thursdays (starting February 1st 2024)s at 3PM PT (Pacific Time) (monthly)](https://zoom.us/j/98329676612?pwd=c0N2bVV1aTh2VzltckdXSitaZXBKQT09)<br>
|[Data Protection](wg-data-protection/README.md)|[data-protection](https://github.com/kubernetes/kubernetes/labels/wg%2Fdata-protection)|* Apps<br>* Storage<br>|* [Xing Yang](https://github.com/xing-yang), VMware<br>* [Xiangqian Yu](https://github.com/yuxiangqian), Google<br>|* [Slack](https://kubernetes.slack.com/messages/wg-data-protection)<br>* [Mailing List](https://groups.google.com/forum/#!forum/kubernetes-data-protection)|* Regular WG Meeting: [Wednesdays at 9:00 PT (Pacific Time) (bi-weekly)](https://zoom.us/j/6933410772)<br>
|[Device Management](wg-device-management/README.md)|[device-management](https://github.com/kubernetes/kubernetes/labels/wg%2Fdevice-management)|* Architecture<br>* Autoscaling<br>* Network<br>* Node<br>* Scheduling<br>|* [John Belamaric](https://github.com/johnbelamaric), Google<br>* [Kevin Klues](https://github.com/klueska), NVIDIA<br>* [Patrick Ohly](https://github.com/pohly), Intel<br>|* [Slack](https://kubernetes.slack.com/messages/wg-device-management)<br>* [Mailing List](https://groups.google.com/a/kubernetes.io/g/wg-device-management)|* Regular WG Meeting: [Tuesdays at 8:30 PT (Pacific Time) (biweekly)](TBD)<br>
|[etcd Operator](wg-etcd-operator/README.md)|[etcd-operator](https://github.com/kubernetes/kubernetes/labels/wg%2Fetcd-operator)|* Cluster Lifecycle<br>* etcd<br>|* [Benjamin Wang](https://github.com/ahrtr), VMware<br>* [Ciprian Hacman](https://github.com/hakman), Microsoft<br>* [Josh Berkus](https://github.com/jberkus), Red Hat<br>* [James Blair](https://github.com/jmhbnz), Red Hat<br>* [Justin Santa Barbara](https://github.com/justinsb), Google<br>|* [Slack](https://kubernetes.slack.com/messages/wg-etcd-operator)<br>* [Mailing List](https://groups.google.com/u/1/g/etcd-dev)|* Regular WG Meeting: [TBDs at TBD PT (Pacific Time) (bi-weekly)](https://zoom.us/my/cncfetcdproject)<br>
Copy link
Member

@kvaps kvaps Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At our etcd-operator We usually have weekly community meetings every Tuesday at 16:00-17:00 CET, it is 7:00-8:00 am PT, so I would like to suggest the same time if it will be convenient to you.

Suggested change
|[etcd Operator](wg-etcd-operator/README.md)|[etcd-operator](https://github.com/kubernetes/kubernetes/labels/wg%2Fetcd-operator)|* Cluster Lifecycle<br>* etcd<br>|* [Benjamin Wang](https://github.com/ahrtr), VMware<br>* [Ciprian Hacman](https://github.com/hakman), Microsoft<br>* [Josh Berkus](https://github.com/jberkus), Red Hat<br>* [James Blair](https://github.com/jmhbnz), Red Hat<br>* [Justin Santa Barbara](https://github.com/justinsb), Google<br>|* [Slack](https://kubernetes.slack.com/messages/wg-etcd-operator)<br>* [Mailing List](https://groups.google.com/u/1/g/etcd-dev)|* Regular WG Meeting: [TBDs at TBD PT (Pacific Time) (bi-weekly)](https://zoom.us/my/cncfetcdproject)<br>
|[etcd Operator](wg-etcd-operator/README.md)|[etcd-operator](https://github.com/kubernetes/kubernetes/labels/wg%2Fetcd-operator)|* Cluster Lifecycle<br>* etcd<br>|* [Benjamin Wang](https://github.com/ahrtr), VMware<br>* [Ciprian Hacman](https://github.com/hakman), Microsoft<br>* [Josh Berkus](https://github.com/jberkus), Red Hat<br>* [James Blair](https://github.com/jmhbnz), Red Hat<br>* [Justin Santa Barbara](https://github.com/justinsb), Google<br>|* [Slack](https://kubernetes.slack.com/messages/wg-etcd-operator)<br>* [Mailing List](https://groups.google.com/u/1/g/etcd-dev)|* Regular WG Meeting: [Tuesdays at 7:00 PT (Pacific Time) (weekly)](https://zoom.us/my/cncfetcdproject)<br>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will finalize the schedule later (after this PR gets merged).

Comment on lines +133 to +138
wg-etcd-operator-leads:
- ahrtr
- hakman
- jberkus
- jmhbnz
- justinsb
Copy link
Member

@kvaps kvaps Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is applicable I'd like also to be in this list to represent our community.

Suggested change
wg-etcd-operator-leads:
- ahrtr
- hakman
- jberkus
- jmhbnz
- justinsb
wg-etcd-operator-leads:
- ahrtr
- hakman
- jberkus
- jmhbnz
- justinsb
- kvaps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for volunteering for the working group! This WG isn't a standing body to represent all etcd operators, though. It's a specific one-time effort to create an official Kubernetes-supported operator. As part of that, we'll be evaluating existing operators to determine if any of them can become the core of this new operator. That means that having the author of one such operator making that evaluation, as a WG chair, isn't a good idea.

You are very welcome to participate in the working group once it gets going, including meetings, issues, commentary, and roadmap.

@neolit123
Copy link
Member

neolit123 commented Jul 19, 2024

/hold cancel
thank you everyone for commenting.
(4 steering votes were added)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit e735bd5 into kubernetes:master Jul 19, 2024
3 checks passed
@ahrtr ahrtr deleted the wg_etcd_operator_20240527 branch July 19, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.