Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Add Linux install command for Mint #1727

Closed
wants to merge 5 commits into from
Closed

[Documentation] Add Linux install command for Mint #1727

wants to merge 5 commits into from

Conversation

merobi-hub
Copy link

@merobi-hub merobi-hub commented Oct 7, 2023 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

The Linux installation command does not work for Linux Mint: the placement of the cURL output parameter and argument (-o kompose) causes the command not to execute. This adds a command specifically for Linux Mint. Tested on Mint and Ubuntu.

Special notes for your reviewer:

@merobi-hub
Fixes linux install cmd.
37e3c40 
Signed-off-by: Michael Robinson <merobi@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 7, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 7, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: merobi-hub
Once this PR has been reviewed and has the lgtm label, please assign sebgoa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @merobi-hub!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 7, 2023
@merobi-hub
Adds linux command for mint instead of changing the command.
90f2962 
Signed-off-by: Michael Robinson <merobi@gmail.com>
@merobi-hub merobi-hub changed the title [Documentation] Fix Linux install command [Documentation] Add Linux install command for Mint Oct 7, 2023
@merobi-hub
Adds linux mint command to index.
c3dcc26 
Signed-off-by: Michael Robinson <merobi@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2023
@merobi-hub
XFixes command headings in install instructions.
9924eb1 
Signed-off-by: merobi-hub <merobi@gmail.com>
@merobi-hub
Fixes and updates linux install commands in index.
3db11fe 
Signed-off-by: merobi-hub <merobi@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2023
cdrage
cdrage reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we wont be adding instructions for Mint :( Using -o before not after is due to an old curl version.

@cdrage cdrage closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage left review comments

@ngtuna ngtuna Awaiting requested review from ngtuna

@sebgoa sebgoa Awaiting requested review from sebgoa

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merobi-hub @k8s-ci-robot @cdrage