remove status field from generated yaml

[shubhindia]

/kind feature

What type of PR is this?

Whenever the k8s yamls are generated, since status field is part of APIs, it is being added in the generated yamls, which is fine but should not be there since the objects are not applied yet.

What this PR does / why we need it:

This just adds a simple hack to remove the status field from generated yamls

Which issue(s) this PR fixes:

Fixes #975

[k8s-ci-robot]

@shubhindia: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

/kind fix

What type of PR is this?

Whenever the k8s yamls are generated, since status field is part of APIs, it is being added in the generated yamls, which is fine but should not be there since the objects are not applied yet.

What this PR does / why we need it:

This just adds a simple hack to remove the status field from generated yamls

Which issue(s) this PR fixes:

Fixes #975

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shubhindia
Once this PR has been reviewed and has the lgtm label, please assign ahmedgrati for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @shubhindia!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[AhmedGrati]

Thanks for the PR @shubhindia. I think removing the status should be okay, as it is not really needed. However, You should change the manifests in the e2e tests accordingly in order for the e2e tests to pass successfully. wdyt @cdrage?

[cdrage]

Thanks for the PR @shubhindia. I think removing the status should be okay, as it is not really needed. However, You should change the manifests in the e2e tests accordingly in order for the e2e tests to pass successfully. wdyt @cdrage?

Yup! Fix the tests please and we can merge this in. I agree that we do not need status in the output.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AhmedGrati]

ping @shubhindia

[shubhindia]

Acknowledged @AhmedGrati . Will push the changes by Monday.

[shubhindia]

closed in favour of #1746